Reconcile if ExcludeFromRemediation label is removed

In case ExcludeFromRemediation label is present, remediation is skipped.
However if the Node is still unhealthy when the label is removed, it
should be reconciled.

Author: clobrano

Diff for: controllers/nodehealthcheck_controller.go

@@ -357,7 +357,7 @@ func (r *NodeHealthCheckReconciler) Reconcile(ctx context.Context, req ctrl.Requ
 		}
 
 		if r.isNodeRemediationExcluded(&node) {
-			msg := fmt.Sprintf("Skipped remediation because node %s is marked to exclude remediations", node.GetName())
+			msg := fmt.Sprintf("Remediation skipped on node %s: node has Exclude from Remediation label", node.GetName())
 			log.Info(msg)
 			commonevents.WarningEvent(r.Recorder, nhc, utils.EventReasonRemediationSkipped, msg)
 			continue

Diff for: controllers/shared.go

@@ -4,6 +4,7 @@ import (
 	"context"
 
 	"github.com/go-logr/logr"
+	commonLabels "github.com/medik8s/common/pkg/labels"
 
 	v1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
@@ -22,7 +23,17 @@ func nodeUpdateNeedsReconcile(ev event.UpdateEvent) bool {
 	if newNode, ok = ev.ObjectNew.(*v1.Node); !ok {
 		return false
 	}
-	return conditionsNeedReconcile(oldNode.Status.Conditions, newNode.Status.Conditions)
+
+	return labelsNeedsReconcile(oldNode.Labels, newNode.Labels) ||
+		conditionsNeedReconcile(oldNode.Status.Conditions, newNode.Status.Conditions)
+}
+
+func labelsNeedsReconcile(oldLabels, newLabels map[string]string) bool {
+	// Check if the ExcludeFromRemediation label was added or removed
+	_, existsInOldLabels := oldLabels[commonLabels.ExcludeFromRemediation]
+	_, existsInNewLabels := newLabels[commonLabels.ExcludeFromRemediation]
+
+	return existsInOldLabels != existsInNewLabels
 }
 
 func conditionsNeedReconcile(oldConditions, newConditions []v1.NodeCondition) bool {