Skip to content

Make protocol utils more convenient #34

@ThiefMaster

Description

@ThiefMaster
  • find_keys: Print the machine ID at the beginning and try all the known keys of existing machines first since it seems quite common that keys are reused
  • dump_memory: Take the target filename and optional memory range as CLI args

Both are things I manually edited into the code in a very messy way (for the keys I just edited the start value for each key to the one I thought it might be), but they sound like the kind of things that could save everyone a bit of time when adding new machines.

Reusing existing keys would likely require a bit of refactoring since right now they aren't particularly accessible from "outside", but the other suggestion should be quite easy. Happy to send a PR if you are fine with it (and don't mind having clap as a dependency for this script)

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions