Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash collision rate may be higher than it ought to be #1

Open
rsharris opened this issue Feb 5, 2020 · 0 comments
Open

Hash collision rate may be higher than it ought to be #1

rsharris opened this issue Feb 5, 2020 · 0 comments

Comments

@rsharris
Copy link
Collaborator

rsharris commented Feb 5, 2020

(All of the following is hypothetical work, but there is currently no plan to do this.)

Canonicalization of the hash function by using h(forward)+h(revcomp) may be introducing more collisions. The solution would be to use something like min(h(forward),(revcomp)), though this can skew the distribution of bits.

More testing would be needed to determine whether the current canonicalization is really a problem.

If it is a problem, any solution needs to retain backward compatibility so as to insure compatibility with existing files. The BF file format includes a version number -- newer versions of the program would recognize the earlier file versions and use the current hash function with those. Newly created BF files would use the new hash function. Older versions of the program would reject the new files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant