Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make return type of facet search results to a concrete type #805

Open
junghoon-vans opened this issue Jan 22, 2025 · 0 comments · May be fixed by #806
Open

Make return type of facet search results to a concrete type #805

junghoon-vans opened this issue Jan 22, 2025 · 0 comments · May be fixed by #806

Comments

@junghoon-vans
Copy link
Contributor

junghoon-vans commented Jan 22, 2025 •
edited
Loading

Description

The type returning the facet search result is not a concrete type, FacetSearchResult.

Basic example

AS-IS

FacetSearchable facetSearch(String uid, FacetSearchRequest fsr) throws MeilisearchException {
        return httpClient.jsonHandler.decode(rawSearch(uid, fsr), FacetSearchResult.class);
}

TO-BE

FacetSearchResult facetSearch(String uid, FacetSearchRequest fsr) throws MeilisearchException {
        return httpClient.jsonHandler.decode(rawSearch(uid, fsr), FacetSearchResult.class);
}

Other
Even the abstract type FacetSearchable will still work with the above changes.
@junghoon-vans junghoon-vans changed the title Change the return type of search results to a concrete type Make return type of facet search results to a concrete type Jan 22, 2025
@junghoon-vans junghoon-vans linked a pull request Jan 22, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make return type of facet-search to concrete type results. junghoon-vans/meilisearch-java
1 participant
@junghoon-vans