Merge #385

385: Fix will_paginate crash when Meilisearch disabled  r=ellnix a=ellnix

# Pull Request

## Related issue
Fixes #382

Using `Meilisearch::Rails.active?` as an alternative to checking that the objects being replaced are actually `NullObject`.

For an alternative solution see #383

The advantage of this approach is that NullObject remains opaque and requires no special treatment, and the logic is much easier to follow (in my opinion).


Co-authored-by: ellnix <ellnix@disroot.org>

Author: meili-bors[bot]

lib/meilisearch/rails/pagination/will_paginate.rb

@@ -10,6 +10,12 @@ module Rails
     module Pagination
       class WillPaginate
         def self.create(results, total_hits, options = {})
+          unless MeiliSearch::Rails.active?
+            total_hits = 0
+            options[:page] = 1
+            options[:per_page] = 1
+          end
+
           ::WillPaginate::Collection.create(options[:page], options[:per_page], total_hits) do |pager|
             pager.replace results
           end

spec/pagination/will_paginate_spec.rb

@@ -42,4 +42,15 @@
   it 'respects max_total_hits' do
     expect(Movie.search('*').count).to eq(5)
   end
+
+  it 'does not crash when meilisearch is disabled' do
+    MeiliSearch::Rails.configuration[:active] = false
+
+    expect do
+      Movie.search ''
+    end.not_to raise_error
+
+  ensure
+    MeiliSearch::Rails.configuration[:active] = true
+  end
 end