Can have Ppx_deriving_json_runtime.Primitives working internally?

[pedrobslisboa]

Description

I'm curious about it. We have to add Ppx_deriving_json_runtime.Primitives for every usage; can we have it internally?

Like (Code just as a sample, not tested or something):

let is_primitive = (* ... *)
let prefix = if (is_primitive) then ("Ppx_deriving_json_runtime.Primitives." ^ prefix) else prefix
let gen_name n = sprintf "%s_%s" prefix n in

Is it to avoid depending on Ppx_deriving_json_runtime.Primitives name, as it can break if the name changes?
What is the motivation?

[davesnx]

The only reason I can think of not doing this is to override the primitives such as string/int/..., so I propose to make things rare a bit harder for those use-cases and provide a section on the docs explaining how to do it:

module Ppx_deriving_json_runtime = struct
    include Ppx_deriving_json_runtime
    module Primitives = struct
        include Ppx_deriving_json_runtime.Primitives
        let string = (* ... *)
    end
end

and keep the inlining inside the ppx, as @pedrobslisboa suggests.

[andreypopp]

I don't think this is a good idea for the reasons stated in the linked ppx_deriving_router issue. Better to stay consistent. If the local open in a module is too annoying, or needs to be spread in multiple modules, can always add -open ... arguments via dune's (flags ...) stanza.