Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search functionality #22

Closed
melihaksoy opened this issue Jul 26, 2019 · 5 comments
Closed

Search functionality #22

melihaksoy opened this issue Jul 26, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@melihaksoy
Copy link
Owner

melihaksoy commented Jul 26, 2019

Need to add search functionality that runs on different feature, that will present query results in a separate list. We should use https://launchlibrary.net/1.4/launch method - there are examples under section.

Documentation: https://launchlibrary.net/docs/1.4.1/api.html

@melihaksoy melihaksoy added the enhancement New feature or request label Jul 26, 2019
@melihaksoy melihaksoy self-assigned this Jul 26, 2019
@bansalayush
Copy link

@melihaksoy Are you looking for maintainers ?

@melihaksoy
Copy link
Owner Author

@bansalayush For sure, it'd be nice to have contributions. I have some other features in mind that I need to create in issue list, before this repo actually starts represents a all-around example.

@bansalayush
Copy link

I didn't get fetching search data rather than searching through paged data part. Can you help me out ?

@melihaksoy
Copy link
Owner Author

I just updated description. I think UX wise having a separate feature for search is not a bad idea - just like launches & detail - this may come in handy in terms of decoupling.

@melihaksoy
Copy link
Owner Author

Closing this as it'll be part of #21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants