Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use fake archive version "1.0" if unknown #79

Open
guillermocalvo opened this issue Oct 9, 2024 · 0 comments · May be fixed by #80
Open

Don't use fake archive version "1.0" if unknown #79

guillermocalvo opened this issue Oct 9, 2024 · 0 comments · May be fixed by #80

Comments

@guillermocalvo
Copy link
Contributor

This plugin currently uses a fake version number "1.0" when the archive version cannot be determined:

for (File file : files) {
    archives.add(new JApiCmpWorkerAction.Archive(file, "1.0"));
}

Considering that 1.0 can be easily confused with a valid version number, I'd prefer the archive version to be set to something conspicuous like unknown version.
@guillermocalvo guillermocalvo linked a pull request Oct 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix archive versions guillermocalvo/japicmp-gradle-plugin
1 participant
@guillermocalvo