Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding same document multiple times should reject that in search level #1733

Open
munjalmukul opened this issue Aug 22, 2024 · 2 comments · May be fixed by #1778
Open

adding same document multiple times should reject that in search level #1733

munjalmukul opened this issue Aug 22, 2024 · 2 comments · May be fixed by #1778
Assignees
Labels
enhancement New feature or request

Comments

@munjalmukul
Copy link

🚀 The feature

How Its Working Currently Right now If I am adding same document twice its first searching memories and then updating, adding or deleting memory.

How It Should be There should be a layer at embedding search level so it reject the duplicate document to save llm cost.

Motivation, pitch

There are times when duplicate documents are uploaded by user so I dont want to send that document to llm so cost can be saved.

@Dev-Khant Dev-Khant added the enhancement New feature or request label Aug 25, 2024
@NavyaAlapati13
Copy link
Contributor

@Dev-Khant I am working on this enhancement, can you assign me this this issue? Looking forward to share the PR soon.

@Dev-Khant
Copy link
Collaborator

Sure @NavyaAlapati13, Thanks for working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants