-
Notifications
You must be signed in to change notification settings - Fork 26
/
Copy pathtortoise_webhook_test.go
275 lines (243 loc) · 12.9 KB
/
tortoise_webhook_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
/*
MIT License
Copyright (c) 2023 mercari
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
*/
package v1beta3
import (
"bytes"
"context"
"errors"
"os"
"path/filepath"
"time"
v1 "k8s.io/api/apps/v1"
autoscalingv2 "k8s.io/api/autoscaling/v2"
apierrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/yaml"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
)
func mutateTest(before, after, deployment, hpa string) {
ctx := context.Background()
y, err := os.ReadFile(deployment)
Expect(err).NotTo(HaveOccurred())
deploy := &v1.Deployment{}
err = yaml.NewYAMLOrJSONDecoder(bytes.NewReader(y), 4096).Decode(deploy)
Expect(err).NotTo(HaveOccurred())
err = k8sClient.Create(ctx, deploy)
Expect(err).NotTo(HaveOccurred())
defer func() {
err = k8sClient.Delete(ctx, deploy)
Expect(err).NotTo(HaveOccurred())
}()
if hpa != "" {
y, err = os.ReadFile(hpa)
Expect(err).NotTo(HaveOccurred())
hpaObj := &autoscalingv2.HorizontalPodAutoscaler{}
err = yaml.NewYAMLOrJSONDecoder(bytes.NewReader(y), 4096).Decode(hpaObj)
Expect(err).NotTo(HaveOccurred())
err = k8sClient.Create(ctx, hpaObj)
Expect(err).NotTo(HaveOccurred())
defer func() {
err = k8sClient.Delete(ctx, hpaObj)
Expect(err).NotTo(HaveOccurred())
}()
}
y, err = os.ReadFile(before)
Expect(err).NotTo(HaveOccurred())
beforeTortoise := &Tortoise{}
err = yaml.NewYAMLOrJSONDecoder(bytes.NewReader(y), 4096).Decode(beforeTortoise)
Expect(err).NotTo(HaveOccurred())
err = k8sClient.Create(ctx, beforeTortoise)
Expect(err).NotTo(HaveOccurred())
defer func() {
err = k8sClient.Delete(ctx, beforeTortoise)
Expect(err).NotTo(HaveOccurred())
}()
ret := &Tortoise{}
err = k8sClient.Get(ctx, types.NamespacedName{Name: beforeTortoise.GetName(), Namespace: beforeTortoise.GetNamespace()}, ret)
Expect(err).NotTo(HaveOccurred())
y, err = os.ReadFile(after)
Expect(err).NotTo(HaveOccurred())
afterTortoise := &Tortoise{}
err = yaml.NewYAMLOrJSONDecoder(bytes.NewReader(y), 4096).Decode(afterTortoise)
Expect(err).NotTo(HaveOccurred())
Expect(ret.Spec).Should(Equal(afterTortoise.Spec))
}
func validateCreationTest(tortoise, hpa, deployment string, valid bool) {
ctx := context.Background()
y, err := os.ReadFile(deployment)
Expect(err).NotTo(HaveOccurred())
deploy := &v1.Deployment{}
err = yaml.NewYAMLOrJSONDecoder(bytes.NewReader(y), 4096).Decode(deploy)
Expect(err).NotTo(HaveOccurred())
err = k8sClient.Create(ctx, deploy)
Expect(err).NotTo(HaveOccurred())
defer func() {
err = k8sClient.Delete(ctx, deploy)
Expect(err).NotTo(HaveOccurred())
}()
if hpa != "" {
y, err = os.ReadFile(hpa)
Expect(err).NotTo(HaveOccurred())
hpaObj := &autoscalingv2.HorizontalPodAutoscaler{}
err = yaml.NewYAMLOrJSONDecoder(bytes.NewReader(y), 4096).Decode(hpaObj)
Expect(err).NotTo(HaveOccurred())
err = k8sClient.Create(ctx, hpaObj)
Expect(err).NotTo(HaveOccurred())
defer func() {
err = k8sClient.Delete(ctx, hpaObj)
Expect(err).NotTo(HaveOccurred())
}()
}
y, err = os.ReadFile(tortoise)
Expect(err).NotTo(HaveOccurred())
tortoiseObj := &Tortoise{}
err = yaml.NewYAMLOrJSONDecoder(bytes.NewReader(y), 4096).Decode(tortoiseObj)
Expect(err).NotTo(HaveOccurred())
err = k8sClient.Create(ctx, tortoiseObj)
if valid {
Expect(err).NotTo(HaveOccurred(), "Tortoise: %v", tortoiseObj)
// cleanup
err = k8sClient.Delete(ctx, tortoiseObj)
Expect(err).NotTo(HaveOccurred())
} else {
Expect(err).To(HaveOccurred(), "Tortoise: %v", tortoiseObj)
statusErr := &apierrors.StatusError{}
Expect(errors.As(err, &statusErr)).To(BeTrue())
expected := tortoiseObj.Annotations["message"]
Expect(statusErr.ErrStatus.Message).To(ContainSubstring(expected))
}
}
func validateUpdateTest(tortoise, existingTortoise, hpa, deployment string, valid bool) {
ctx := context.Background()
y, err := os.ReadFile(deployment)
Expect(err).NotTo(HaveOccurred())
deploy := &v1.Deployment{}
err = yaml.NewYAMLOrJSONDecoder(bytes.NewReader(y), 4096).Decode(deploy)
Expect(err).NotTo(HaveOccurred())
err = k8sClient.Create(ctx, deploy)
Expect(err).NotTo(HaveOccurred())
defer func() {
err = k8sClient.Delete(ctx, deploy)
Expect(err).NotTo(HaveOccurred())
}()
y, err = os.ReadFile(hpa)
Expect(err).NotTo(HaveOccurred())
hpaObj := &autoscalingv2.HorizontalPodAutoscaler{}
err = yaml.NewYAMLOrJSONDecoder(bytes.NewReader(y), 4096).Decode(hpaObj)
Expect(err).NotTo(HaveOccurred())
err = k8sClient.Create(ctx, hpaObj)
Expect(err).NotTo(HaveOccurred())
defer func() {
err = k8sClient.Delete(ctx, hpaObj)
Expect(err).NotTo(HaveOccurred())
}()
y, err = os.ReadFile(existingTortoise)
Expect(err).NotTo(HaveOccurred())
tor := &Tortoise{}
err = yaml.NewYAMLOrJSONDecoder(bytes.NewReader(y), 4096).Decode(tor)
Expect(err).NotTo(HaveOccurred())
status := tor.Status
err = k8sClient.Create(ctx, tor)
err = k8sClient.Get(ctx, types.NamespacedName{Name: tor.GetName(), Namespace: tor.GetNamespace()}, tor)
Expect(err).NotTo(HaveOccurred())
tor.Status = status
err = k8sClient.Status().Update(ctx, tor)
Expect(err).NotTo(HaveOccurred())
time.Sleep(time.Second)
y, err = os.ReadFile(tortoise)
Expect(err).NotTo(HaveOccurred())
tor = &Tortoise{}
err = yaml.NewYAMLOrJSONDecoder(bytes.NewReader(y), 4096).Decode(tor)
Expect(err).NotTo(HaveOccurred())
t := &Tortoise{}
err = k8sClient.Get(ctx, types.NamespacedName{Name: tor.GetName(), Namespace: tor.GetNamespace()}, t)
Expect(err).NotTo(HaveOccurred())
t.Spec = tor.Spec
err = k8sClient.Update(ctx, t)
if valid {
Expect(err).NotTo(HaveOccurred(), "Tortoise: %v", tor)
// cleanup
err = k8sClient.Delete(ctx, tor)
Expect(err).NotTo(HaveOccurred())
} else {
Expect(err).To(HaveOccurred(), "Tortoise: %v", tor)
statusErr := &apierrors.StatusError{}
Expect(errors.As(err, &statusErr)).To(BeTrue())
expected := tor.Annotations["message"]
Expect(statusErr.ErrStatus.Message).To(ContainSubstring(expected))
}
}
var _ = Describe("Tortoise Webhook", func() {
Context("mutating", func() {
It("nothing to do", func() {
mutateTest(filepath.Join("testdata", "mutating", "nothing-to-do", "before.yaml"), filepath.Join("testdata", "mutating", "nothing-to-do", "after.yaml"), filepath.Join("testdata", "mutating", "nothing-to-do", "deployment.yaml"), "")
})
It("nothing to do (empty autoscaling policy)", func() {
mutateTest(filepath.Join("testdata", "mutating", "no-autoscaling-policy", "before.yaml"), filepath.Join("testdata", "mutating", "no-autoscaling-policy", "after.yaml"), filepath.Join("testdata", "mutating", "no-autoscaling-policy", "deployment.yaml"), "")
})
It("should mutate a Tortoise with istio", func() {
mutateTest(filepath.Join("testdata", "mutating", "with-istio", "before.yaml"), filepath.Join("testdata", "mutating", "with-istio", "after.yaml"), filepath.Join("testdata", "mutating", "with-istio", "deployment.yaml"), "")
})
It("should mutate a Tortoise which some autoscalingPolicy is specified, but not all", func() {
mutateTest(filepath.Join("testdata", "mutating", "some-specified-others-not", "before.yaml"), filepath.Join("testdata", "mutating", "some-specified-others-not", "after.yaml"), filepath.Join("testdata", "mutating", "some-specified-others-not", "deployment.yaml"), "")
})
})
Context("validating(creation)", func() {
It("should create a valid Tortoise", func() {
validateCreationTest(filepath.Join("testdata", "validating", "success", "tortoise.yaml"), filepath.Join("testdata", "validating", "success", "hpa.yaml"), filepath.Join("testdata", "validating", "success", "deployment.yaml"), true)
})
It("should create a valid Tortoise for the deployment with istio", func() {
validateCreationTest(filepath.Join("testdata", "validating", "success-with-istio", "tortoise.yaml"), filepath.Join("testdata", "validating", "success-with-istio", "hpa.yaml"), filepath.Join("testdata", "validating", "success-with-istio", "deployment.yaml"), true)
})
It("invalid: Tortoise is targetting the resource other than Deployment", func() {
validateCreationTest(filepath.Join("testdata", "validating", "not-targetting-deployment", "tortoise.yaml"), filepath.Join("testdata", "validating", "not-targetting-deployment", "hpa.yaml"), filepath.Join("testdata", "validating", "not-targetting-deployment", "deployment.yaml"), false)
})
It("invalid: Tortoise has resource policy for non-existing container", func() {
validateCreationTest(filepath.Join("testdata", "validating", "useless-policy", "tortoise.yaml"), filepath.Join("testdata", "validating", "useless-policy", "hpa.yaml"), filepath.Join("testdata", "validating", "useless-policy", "deployment.yaml"), false)
})
})
Context("validating(updating)", func() {
It("should update a valid Tortoise", func() {
validateUpdateTest(filepath.Join("testdata", "validating", "success", "tortoise.yaml"), filepath.Join("testdata", "validating", "success", "tortoise.yaml"), filepath.Join("testdata", "validating", "success", "hpa.yaml"), filepath.Join("testdata", "validating", "success", "deployment.yaml"), true)
})
It("should update a valid Tortoise for the deployment with istio", func() {
validateUpdateTest(filepath.Join("testdata", "validating", "success-with-istio", "tortoise.yaml"), filepath.Join("testdata", "validating", "success-with-istio", "tortoise.yaml"), filepath.Join("testdata", "validating", "success-with-istio", "hpa.yaml"), filepath.Join("testdata", "validating", "success-with-istio", "deployment.yaml"), true)
})
It("successfully remove horizontal", func() {
validateUpdateTest(filepath.Join("testdata", "validating", "success-remove-all-horizontal", "updating-tortoise.yaml"), filepath.Join("testdata", "validating", "success-remove-all-horizontal", "before-tortoise.yaml"), filepath.Join("testdata", "validating", "success-remove-all-horizontal", "hpa.yaml"), filepath.Join("testdata", "validating", "success-remove-all-horizontal", "deployment.yaml"), true)
})
It("no horizontal policy exists and the deletion policy is NoDelete", func() {
validateUpdateTest(filepath.Join("testdata", "validating", "no-horizontal-with-no-deletion", "updating-tortoise.yaml"), filepath.Join("testdata", "validating", "no-horizontal-with-no-deletion", "before-tortoise.yaml"), filepath.Join("testdata", "validating", "no-horizontal-with-no-deletion", "hpa.yaml"), filepath.Join("testdata", "validating", "no-horizontal-with-no-deletion", "deployment.yaml"), false)
})
It("no horizontal policy exists and HPA is specified", func() {
validateUpdateTest(filepath.Join("testdata", "validating", "no-horizontal-with-hpa", "updating-tortoise.yaml"), filepath.Join("testdata", "validating", "no-horizontal-with-hpa", "before-tortoise.yaml"), filepath.Join("testdata", "validating", "no-horizontal-with-hpa", "hpa.yaml"), filepath.Join("testdata", "validating", "no-horizontal-with-hpa", "deployment.yaml"), false)
})
It("can remove HPA name in tortoise spec", func() {
validateUpdateTest(filepath.Join("testdata", "validating", "success-remove-hpa", "tortoise.yaml"), filepath.Join("testdata", "validating", "success-remove-hpa", "before-tortoise.yaml"), filepath.Join("testdata", "validating", "success-remove-hpa", "hpa.yaml"), filepath.Join("testdata", "validating", "success-remove-hpa", "deployment.yaml"), true)
})
It("can set HPA name in tortoise spec which is the same as status", func() {
validateUpdateTest(filepath.Join("testdata", "validating", "success-set-the-same", "tortoise.yaml"), filepath.Join("testdata", "validating", "success-set-the-same", "before-tortoise.yaml"), filepath.Join("testdata", "validating", "success-set-the-same", "hpa.yaml"), filepath.Join("testdata", "validating", "success-set-the-same", "deployment.yaml"), true)
})
It("cannot set HPA name in tortoise spec which is different from status", func() {
validateUpdateTest(filepath.Join("testdata", "validating", "success-set-different", "tortoise.yaml"), filepath.Join("testdata", "validating", "success-set-different", "before-tortoise.yaml"), filepath.Join("testdata", "validating", "success-set-different", "hpa.yaml"), filepath.Join("testdata", "validating", "success-set-different", "deployment.yaml"), false)
})
})
})