-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rendering should not depend on a CSS reset #4907
Labels
Status: Triage
Needs to be verified, categorized, etc
Type: Bug / Error
Something isn't working or is incorrect
Comments
silverwind
added
Status: Triage
Needs to be verified, categorized, etc
Type: Bug / Error
Something isn't working or is incorrect
labels
Oct 4, 2023
Hey |
silverwind
changed the title
Incorrect rendering without a CSS reset on the page
mermaid rendering should not depend on a CSS reset
Oct 7, 2023
lunny
pushed a commit
to go-gitea/gitea
that referenced
this issue
Oct 8, 2023
Fixes: #27435 Related: mermaid-js/mermaid#4907 <img width="924" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/494a1d2e-4c56-48d0-9843-82a5e5aa977e">
silverwind
added a commit
to silverwind/gitea
that referenced
this issue
Oct 8, 2023
Fixes: go-gitea#27435 Related: mermaid-js/mermaid#4907 <img width="924" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/494a1d2e-4c56-48d0-9843-82a5e5aa977e">
silverwind
added a commit
to silverwind/gitea
that referenced
this issue
Oct 8, 2023
Fixes: go-gitea#27435 Related: mermaid-js/mermaid#4907 <img width="924" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/494a1d2e-4c56-48d0-9843-82a5e5aa977e">
KN4CK3R
pushed a commit
to go-gitea/gitea
that referenced
this issue
Oct 8, 2023
Backport #27503 to 1.21 Fixes: #27435 Related: mermaid-js/mermaid#4907 <img width="924" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/494a1d2e-4c56-48d0-9843-82a5e5aa977e">
KN4CK3R
pushed a commit
to go-gitea/gitea
that referenced
this issue
Oct 8, 2023
Backport #27503 to 1.20 Fixes: #27435 Related: mermaid-js/mermaid#4907 <img width="924" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/494a1d2e-4c56-48d0-9843-82a5e5aa977e">
silverwind
changed the title
mermaid rendering should not depend on a CSS reset
Rendering should not depend on a CSS reset
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Triage
Needs to be verified, categorized, etc
Type: Bug / Error
Something isn't working or is incorrect
Description
The mermaid rendering depends on certain CSS styles like
p {margin: 0}
to correctly render, which is bad because it forces a dependency on a CSS reset (which one?) onto the consumer.On
mermaid.live
these styles are provided by the tailwindcss base, but it should not be assumed that the consumer also uses tailwindcss or any other CSS reset. It should render correctly with default browser styles.Steps to reproduce
Screenshots
Actual:
Expected:
Setup
Suggested Solutions
Either add the missing styles via JavaScript or provide a (hopefully scoped) CSS file as part of the npm module so that mermaid charts render correctly with default browser styles.
The text was updated successfully, but these errors were encountered: