Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize the CI #4916

Open
sidharthv96 opened this issue Oct 6, 2023 · 3 comments
Open

Stabilize the CI #4916

sidharthv96 opened this issue Oct 6, 2023 · 3 comments
Labels
Status: Triage Needs to be verified, categorized, etc

Comments

@sidharthv96
Copy link
Member

We're getting intermittent failures in CI, which reduces our ability to spot actual issues.

157c90e and c63ea3e had completely unrelated failures, which were fixed when rerun.

@sidharthv96
Copy link
Member Author

sidharthv96 commented Oct 6, 2023

I'm uncertain if merging next would fix some of these, as the build pipeline changes to esbuild.

cc @aloisklink @nirname @Yokozuna59

@github-actions github-actions bot added the Status: Triage Needs to be verified, categorized, etc label Oct 6, 2023
@nirname
Copy link
Contributor

nirname commented Oct 6, 2023

We need more examples when we are talking about unstable CI. This very example that you have provided is related to gantt optimization specifically, I presume. I can reproduce this failure locally, without CI. It does not work in Docker environment. May be I'll give it a shot and track down the problem.

If there are more tests scenarios which produce unpredictable results in CI, that worth investigating. We need like a critical mass of examples to figure out what is going on. Too many different potential roots to judge by one occasion.

One of the symptoms of "unstable CI" is that rerunning action helps to fix it, as you have already mentioned. I'll try to search for more representative cases, apart from those two.

@sidharthv96
Copy link
Member Author

Nope, both the failures have nothing to do with Gantt.
They were two different tests in flowchart, failing due to two different reasons (both seemed to be build related)

image image

The Gantt failure was not a flaky failure, but transient failures like this have a part in why that issue was overlooked.

@jgreywolf jgreywolf added include and removed include labels Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc
Projects
None yet
Development

No branches or pull requests

3 participants