Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme variables are missing in docs #4931

Open
Mister-Hope opened this issue Oct 9, 2023 · 0 comments
Open

Theme variables are missing in docs #4931

Mister-Hope opened this issue Oct 9, 2023 · 0 comments
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@Mister-Hope
Copy link
Contributor

Mister-Hope commented Oct 9, 2023

Description

There are a lot of theme variables which is actually working, but can not be found in docs, we cannot expect every user to read source code themselves.

An example is attributeBackgroundColorOdd and attributeBackgroundColorEven (for er chart), can only be found at source code, and a related bug report at https://github.com/orgs/vuepress-theme-hope/discussions/3433

Suggested Solutions

I would recommend adding theme in docs, and I would like to submit a pr.

The only question is that shall I add them at the bottom of chart page, or inside config section about themeVariables?

@Mister-Hope Mister-Hope added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Oct 9, 2023
@jgreywolf jgreywolf added include and removed include labels Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

No branches or pull requests

2 participants