Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples Illegible in Docs Without Highlighting #4971

Closed
mjmatthiesen opened this issue Oct 20, 2023 · 5 comments
Closed

Examples Illegible in Docs Without Highlighting #4971

mjmatthiesen opened this issue Oct 20, 2023 · 5 comments
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@mjmatthiesen
Copy link

Description

When I look at diagram example code, it's grey on grey, completely illegible. I have to highlight to read.

Steps to reproduce

  1. Open Docs
  2. Go to timeline example
  3. Try to read (you cannot)

Screenshots

image

Code Sample

No response

Setup

  • Mermaid version: Yes
  • Browser and Version: Firefox 118.0.2

Suggested Solutions

Make it legible. No reason the example text shouldn't be black.

Additional Context

Using superior light theme.
@mjmatthiesen mjmatthiesen added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Oct 20, 2023
@huynhicode
Copy link
Member

@mjmatthiesen thanks for reporting!

This is being looked into. We will update this issue when it has been resolved.

@marameref
Copy link

is this issue open, can i work on it?

@huynhicode huynhicode mentioned this issue Oct 30, 2023
Closed
4 tasks
@huynhicode
Copy link
Member

@marameref Thanks for the interest in contributing!

I have submitted a PR for this issue.

Closing issue - please reopen if needed. Thanks!

@huynhicode huynhicode mentioned this issue Oct 31, 2023
Closed
@nirname
Copy link
Contributor

nirname commented Oct 31, 2023

Should not we keep this issue opened till request is merged?

@nirname nirname reopened this Oct 31, 2023
@huynhicode huynhicode mentioned this issue Nov 2, 2023
Closed
@Yokozuna59 Yokozuna59 mentioned this issue Nov 8, 2023
Closed
@jgreywolf jgreywolf added include roadmap items to add to roadmap for auto workflow and removed include roadmap items to add to roadmap for auto workflow labels Nov 16, 2023
@huynhicode
Copy link
Member

@mjmatthiesen and all - this has been resolved with PR-4924.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Docs: add light syntax highlighting theme mermaid-js/mermaid
5 participants
@jgreywolf @nirname @mjmatthiesen @huynhicode @marameref