Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to the documentation from mermail.live are broken #4989

Closed
nirname opened this issue Oct 26, 2023 · 6 comments
Closed

Links to the documentation from mermail.live are broken #4989

nirname opened this issue Oct 26, 2023 · 6 comments
Labels
Area: Documentation Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@nirname
Copy link
Contributor

nirname commented Oct 26, 2023

Description

When editing diagram in mermaid.live docs button is supposed to lead me directly to the documentation for the graph type I am editing. Now it leads only to the main page. Seems that rerouting inside documentation is broken.

Steps to reproduce

  1. Open mermaid.live
  2. Pick any of sample diagrams
  3. Click "docs" button

Screenshots

image

Code Sample

These links are broken

https://mermaid.js.org/#/sequenceDiagram
https://mermaid.js.org/#/flowchart
https://mermaid.js.org/#/classDiagram

etc...
did not have checked each and every

Setup

  • Mermaid version: 10.6.0 (on the documentation website)
  • Browser and Version: Chrome

Suggested Solutions

Additional Context

No response

@nirname nirname added Type: Bug / Error Something isn't working or is incorrect Status: Triage Needs to be verified, categorized, etc labels Oct 26, 2023
@LadegbayeStella
Copy link

Please, assign to me

@shubhusion
Copy link

kindly assign this to me

@nirname
Copy link
Contributor Author

nirname commented Oct 27, 2023

@shubhusion @LadegbayeStella no need to assign. Simply open PR and link it to this request. If you had already started but not have finished yet, you can mark this PR as a draft, and click ready for review when it's done.
When using special Github keywords like resolves linking will be done automatically. And even if you give up implementing feature half-way every member of the community will see this PR and can take an inspiration from it.

@huynhicode
Copy link
Member

@nirname Thanks for catching this! Wonder if this issue should be cross-referenced in Mermaid Live issues.

@sidharthv96
Copy link
Member

For context:

  1. The redirect used to work properly. (Logic is in redirects.ts file)
  2. Now, it works locally, but throws 404 in production.

Possible issues: Version upgrade of vitepress ?

@sidharthv96
Copy link
Member

@nirname Thanks for catching this! Wonder if this issue should be cross-referenced in Mermaid Live issues.

It's not technically a LE bug, as those old URLs should work here.
But as you've fixed it in LE, we can avoid an unnecessary redirect now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Documentation Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

No branches or pull requests

6 participants