Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate configuration types #5125

Closed
dsogari opened this issue Dec 7, 2023 · 0 comments · Fixed by #5126
Closed

Duplicate configuration types #5125

dsogari opened this issue Dec 7, 2023 · 0 comments · Fixed by #5126
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@dsogari
Copy link
Contributor

dsogari commented Dec 7, 2023

Description

Currently, some configuration types listed in packages/mermaid/src/config.type.ts appear duplicated (such as XYChartAxisConfig1 and XYChartAxisConfig2). This is caused by an issue on the json-schema-to-typescript package.

I have a fix that resolves this, which I will submit in a new PR soon.

Steps to reproduce

  1. Clone the repo.
  2. Open the packages/mermaid/src/config.type.ts file.
  3. See the duplicated types XYChartAxisConfig1 and XYChartAxisConfig2.

Screenshots

No response

Code Sample

No response

Setup

No response

Suggested Solutions

No response

Additional Context

No response

@dsogari dsogari added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants