Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when "self" in a node identifier, using GH mermaid: "Unable to render rich display: Diagram error not found" #5317

Closed
ringerc opened this issue Feb 25, 2024 · 2 comments
Labels
Close after 30 days Close issue if no response after 30 days Status: Awaiting Reply Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@ringerc
Copy link

ringerc commented Feb 25, 2024

Description

Mermaid js as adopted by Github's Markdown renderer does not like the string self appearing in a label for a node.

See the two diagrams below.

Steps to reproduce

flowchart TD;

  my_self["me"]
  other["thing"]
  my_self --> other
Loading

vs

flowchart TD;

  my_thing["me"]
  other["thing"]
  my_thing --> other
Loading

Screenshots

No response

Code Sample

No response

Setup

  • Mermaid version:
  • Browser and Version: [Chrome, Edge, Firefox]

Suggested Solutions

  • Emit a useful error with the actual error from the renderer
  • Don't special case string names

Additional Context

No response

@ringerc ringerc added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Feb 25, 2024
@nirname
Copy link
Contributor

nirname commented Jun 19, 2024

@ringerc it seems that at the moment both diagrams work just fine at mermaid.live and gh as well. Please, check it and confirm or add some more examples.

@nirname nirname added Status: Awaiting Reply Close after 30 days Close issue if no response after 30 days labels Jun 19, 2024
@ringerc
Copy link
Author

ringerc commented Jun 20, 2024

They're rendering here now too. I presume the issue was fixed since when I reported it in Feb. Thanks for checking.

@ringerc ringerc closed this as completed Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Close after 30 days Close issue if no response after 30 days Status: Awaiting Reply Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

No branches or pull requests

2 participants