Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Relation height changed from v10.4.0 - v10.5.0 for class diagrams #5417

Closed
ad1992 opened this issue Mar 26, 2024 · 2 comments
Closed

The Relation height changed from v10.4.0 - v10.5.0 for class diagrams #5417

ad1992 opened this issue Mar 26, 2024 · 2 comments

Comments

@ad1992
Copy link
Contributor

ad1992 commented Mar 26, 2024

Description

For some reason, the relation in class diagrams was updated

In V10.4.0 👇🏻
Screenshot 2024-03-26 at 12 41 24 PM

In v10.5.0 👇🏻
Screenshot 2024-03-26 at 12 39 12 PM
8f-9df7-e18c8fa75925">

As you can see there was a 18 px reduction and also earlier the the triangle in arrow-head was filled with the same color (violet) as the classes where whereas now it is white.

Any idea what caused this and why was it updated? cc @sidharthv96

Steps to reproduce

Mentioned above

Screenshots

Added

Code Sample

No response

Setup

No response

Suggested Solutions

No response

Additional Context

No response

@ad1992 ad1992 added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Mar 26, 2024
@sidharthv96
Copy link
Member

PR: #4804
Issue: #4691

Earlier the path was from one box to the next, with arrow overlaid on top. This resulted in some visual defects, hence the line was drawn till the start of the arrowhead.

Arrow's color being white is to align with sequence diagram standards.

@sidharthv96 sidharthv96 added Type: Question and removed Type: Bug / Error Something isn't working or is incorrect Status: Triage Needs to be verified, categorized, etc labels Mar 26, 2024
@ad1992
Copy link
Contributor Author

ad1992 commented Mar 26, 2024

PR: #4804 Issue: #4691

Earlier the path was from one box to the next, with arrow overlaid on top. This resulted in some visual defects, hence the line was drawn till the start of the arrowhead.

Arrow's color being white is to align with sequence diagram standards.

yeah was suspecting the same PR but wasn't sure as it was only for sequence diagram as per the code, but now it makes sense.
Hence for solid/dotted triangle arrowheads, the change is more visible (since we derive the dimensions of arrow from svg where the length is now shortened)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants