Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash "#" symbol as prefix is not working for sequenceDiagram #5419

Open
dav1tj opened this issue Mar 27, 2024 · 1 comment
Open

Hash "#" symbol as prefix is not working for sequenceDiagram #5419

dav1tj opened this issue Mar 27, 2024 · 1 comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@dav1tj
Copy link

dav1tj commented Mar 27, 2024

Description

When we are using "#" has symbol as prefix in sequence diagram, text becomes empty.

Steps to reproduce

Try to use this code:
sequenceDiagram
actor Alice as #1
actor Bob as Bob
actor actor_sgautk7mz as New Actor

Note over Bob: #55
Bob -->> Bob: new msg
Alice ->> Bob: #66
Bob ->> Alice: Hi Alice

Screenshots

image

Code Sample

No response

Setup

  • Mermaid version:
  • Browser and Version: [Chrome, Edge, Firefox]

Suggested Solutions

No response

Additional Context

No response
@dav1tj dav1tj added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Mar 27, 2024
@sidharthv96
Copy link
Member

Hi @dav1tj, I think I know you from somewhere else ;)

These two PRs are related, major concern is breaking existing diagrams, so if that won't be an issue, we can have this.

Having # at the start of an id seems a bit odd(as it's usually not used, or used as a modifier in coding), what's the use case?

fedarko added a commit to fedarko/strainFlye that referenced this issue Sep 16, 2024
@fedarko
DOC: another linebreak in the flow chart
23e1a8d 
one more thing i forgot to mention in the previous commit -- using
"#" in the node name for "# mutations / Mb" caused the node label
to vanish, presumably because of
mermaid-js/mermaid#5419. the previous commit
fixed this (changing "# mutations" to "Number of mutations"), but this
made the node label a bit too wide (not wide enough to trigger the
other bug documented in the previous commit, but still wide enough to
look a bit off). so anyway this commit adds another <br/> to make the
nodes all have roughly the same size.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sidharthv96 @dav1tj