Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sankey with showValues enabled results in unnecessary crossing of lines #5464

Open
conan-chiles opened this issue Apr 15, 2024 · 0 comments
Open
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@conan-chiles
Copy link

Description

Hi,
with the sankey diagram, the option showValues set to true results in the diagram having unnecessary crossing of lines, making the diagram less readable.

Not 100% sure if this is a bug, or maybe more a feature request where another parameter is required.

examples:

showValues: false

---
config:
  sankey:
    showValues: false
---
sankey-beta
"Year","Q1",10
"Year","Q2",10
"Year","Q3",10
"Year","Q4",10
"Q1","January",2
"Q1","February",2
"Q1","March",6
"Q2","April",6
"Q2","May",2
"Q2","June",2
"Q3","July",2
"Q3","August",6
"Q3","September",2
"Q4","October",6
"Q4","November",2
"Q4","December",2
Loading

showValues: true

---
config:
  sankey:
    showValues: true
---
sankey-beta
"Year","Q1",10
"Year","Q2",10
"Year","Q3",10
"Year","Q4",10
"Q1","January",2
"Q1","February",2
"Q1","March",6
"Q2","April",6
"Q2","May",2
"Q2","June",2
"Q3","July",2
"Q3","August",6
"Q3","September",2
"Q4","October",6
"Q4","November",2
"Q4","December",2
Loading

Steps to reproduce

flick showValues between true and false

---
config:
  sankey:
    showValues: false
---
sankey-beta
"Year","Q1",10
"Year","Q2",10
"Year","Q3",10
"Year","Q4",10
"Q1","January",2
"Q1","February",2
"Q1","March",6
"Q2","April",6
"Q2","May",2
"Q2","June",2
"Q3","July",2
"Q3","August",6
"Q3","September",2
"Q4","October",6
"Q4","November",2
"Q4","December",2

Screenshots

image
image

Code Sample

No response

Setup

  • Mermaid version: v10.9.0
  • Browser and Version: Edge 123.0.2420.97, Firefox 125.0

Suggested Solutions

No response

Additional Context

No response

@conan-chiles conan-chiles added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

No branches or pull requests

1 participant