Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate package size diff on PRs #5235

Merged
merged 16 commits into from
Mar 6, 2024
Merged

Calculate package size diff on PRs #5235

merged 16 commits into from
Mar 6, 2024

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Jan 24, 2024

📑 Summary

Uses ESBuild's Metafile to calculate size change.

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 60dd276
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65e8368c366eb80008ac3e5d
😎 Deploy Preview https://deploy-preview-5235--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.38%. Comparing base (0b0d901) to head (a5196a8).

❗ Current head a5196a8 differs from pull request most recent head 60dd276. Consider uploading reports for the commit 60dd276 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5235      +/-   ##
===========================================
- Coverage    44.67%   44.38%   -0.29%     
===========================================
  Files           25       25              
  Lines         5339     5227     -112     
  Branches        27       25       -2     
===========================================
- Hits          2385     2320      -65     
+ Misses        2953     2906      -47     
  Partials         1        1              
Flag Coverage Δ
unit 44.38% <ø> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@sidharthv96
Copy link
Member Author

image

@sidharthv96 sidharthv96 marked this pull request as draft January 24, 2024 17:16
@sidharthv96 sidharthv96 changed the base branch from next to develop January 24, 2024 17:22
@sidharthv96 sidharthv96 changed the base branch from develop to next January 24, 2024 17:40
@sidharthv96 sidharthv96 marked this pull request as ready for review January 24, 2024 17:41
@mermaid-js mermaid-js deleted a comment from github-actions bot Jan 24, 2024
Copy link
Contributor

No changes in bundle sizes

@sidharthv96 sidharthv96 added Area: DevOps Skip changelog Don't include in the changelog labels Jan 24, 2024
Base automatically changed from next to develop March 6, 2024 09:23
* develop: (280 commits)
  chore: Remove unused imports in block
  Fix spelling
  Update docs
  Lychee ignore chrome webstore
  Update link
  chore(deps): update all patch dependencies
  build(docs): vendor CSS dependencies
  chore(deps): update all minor dependencies
  Ran lint:fix
  Fix chrome webstore url causing 404
  build(deps): update `langium` to `v3` and apply the required changes
  Resolves E2E testing issues and issue #5343
  Fix spelling
  Fix community integrations
  Fix docs
  docs: Fix config
  Update all minor dependencies
  Amend docs to document gitgraph parallel commits
  Fix lint
  Use Yarn Add COREPACK_ENABLE_STRICT
  ...
@sidharthv96 sidharthv96 merged commit 821076b into develop Mar 6, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: DevOps Skip changelog Don't include in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant