Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(class): #5624 Reset direction to default in classDiagram #5625

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Jul 7, 2024

📑 Summary

Reset the direction inside clear function

Resolves #5624

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Jul 7, 2024
Copy link

netlify bot commented Jul 7, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit a80dd71
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/668a751c5b425e0008ab4ded
😎 Deploy Preview https://deploy-preview-5625--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 5.86%. Comparing base (adf4351) to head (a80dd71).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5625   +/-   ##
=======================================
  Coverage     5.86%   5.86%           
=======================================
  Files          274     273    -1     
  Lines        41085   41075   -10     
  Branches       488     512   +24     
=======================================
  Hits          2408    2408           
+ Misses       38677   38667   -10     
Flag Coverage Δ
unit 5.86% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/diagrams/class/classDb.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link

argos-ci bot commented Jul 7, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Jul 7, 2024, 11:05 AM

@sidharthv96 sidharthv96 added this pull request to the merge queue Jul 7, 2024
Merged via the queue into develop with commit b263164 Jul 7, 2024
28 checks passed
@sidharthv96 sidharthv96 deleted the fix/5624_ClassDirection branch July 7, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

classDiagram 'direction RL' state is maintained when removed
1 participant