#4866, #5255 fix: Fixes bug for links to self for nodes inside a cluster

[knsv]

📑 Summary

Fixes a bug where self links fail when the node with the self link is inside a subgraph.

Resolves #4866, #5255

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• [] 💻 have added necessary unit/e2e tests.
• x ] 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
• 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3b3b599

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify]

✅ Deploy Preview for mermaid-js ready!

Name	Link
🔨 Latest commit	3b3b599
🔍 Latest deploy log	https://app.netlify.com/sites/mermaid-js/deploys/66cc8a82d4e2c2000816e7cd
😎 Deploy Preview	https://deploy-preview-5781--mermaid-js.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 58 lines in your changes missing coverage. Please review.

Project coverage is 5.20%. Comparing base (10e05f3) to head (3b3b599).
Report is 4 commits behind head on develop.

Files	Patch %	Lines
...rc/rendering-util/layout-algorithms/dagre/index.js	0.00%	56 Missing ⚠️
...g-util/layout-algorithms/dagre/mermaid-graphlib.js	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #5781      +/-   ##
==========================================
- Coverage     5.20%   5.20%   -0.01%     
==========================================
  Files          322     322              
  Lines        46108   46109       +1     
  Branches       561     561              
==========================================
  Hits          2402    2402              
- Misses       43706   43707       +1     

Flag	Coverage Δ
unit	5.20% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...g-util/layout-algorithms/dagre/mermaid-graphlib.js	0.00% <0.00%> (ø)
...rc/rendering-util/layout-algorithms/dagre/index.js	0.00% <0.00%> (ø)

[argos-ci]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	✅ No changes detected	-	Aug 26, 2024, 2:13 PM