Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/5827 self loops #5828

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Hotfix/5827 self loops #5828

merged 4 commits into from
Sep 6, 2024

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented Sep 6, 2024

📑 Summary

Fix for issues with self-loop breaking in the root.

Resolves #5820, #5822

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • [-] 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@knsv knsv requested a review from ashishjain0512 September 6, 2024 16:48
Copy link

changeset-bot bot commented Sep 6, 2024

🦋 Changeset detected

Latest commit: 4c43d21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Sep 6, 2024
Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 4c43d21
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66db327925106600081aed6f
😎 Deploy Preview https://deploy-preview-5828--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 5.01%. Comparing base (a6dbf0a) to head (4c43d21).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...rc/rendering-util/layout-algorithms/dagre/index.js 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5828   +/-   ##
======================================
  Coverage    5.01%   5.01%           
======================================
  Files         337     336    -1     
  Lines       48084   48075    -9     
  Branches      550     575   +25     
======================================
  Hits         2413    2413           
+ Misses      45671   45662    -9     
Flag Coverage Δ
unit 5.01% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/rendering-util/layout-algorithms/dagre/index.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link

argos-ci bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 added Sep 6, 2024, 4:55 PM

Copy link
Collaborator

@ashishjain0512 ashishjain0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashishjain0512 ashishjain0512 merged commit 145acd0 into master Sep 6, 2024
21 checks passed
@ashishjain0512 ashishjain0512 deleted the hotfix/5827-self-loops branch September 6, 2024 17:16
@github-actions github-actions bot mentioned this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants