Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

computing W_clamp_min #4

Open
rimelcheikh opened this issue Dec 15, 2022 · 0 comments
Open

computing W_clamp_min #4

rimelcheikh opened this issue Dec 15, 2022 · 0 comments

Comments

@rimelcheikh
Copy link

rimelcheikh commented Dec 15, 2022

Hello,
I'm a PhD student working on XAI. And I came across your paper so I decided to test the provided implementation, which I thank you for. The code is very clear and easy to understand !

While studying the code, I noticed the following:
In cce_utils.py, line 68, shouldn't W_clamp_min be computed as

  • (W_clamp_min / (min_margins * concept_norms)).T
  • instead of (W_clamp_min / (max_margins * concept_norms)).T ?

I'm saying this based on equation (6) provided in section 3.2 of your paper. Please correct me if I'm wrong or if I misunderstood something.

Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant