Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: QMC5883L Has the wrong address in the config #4144

Closed
Africmod opened this issue Jun 19, 2024 · 6 comments · Fixed by #4740
Closed

[Bug]: QMC5883L Has the wrong address in the config #4144

Africmod opened this issue Jun 19, 2024 · 6 comments · Fixed by #4740
Labels
bug Something isn't working

Comments

@Africmod
Copy link

Category

Hardware Compatibility

Hardware

Not Applicable

Firmware Version

2.3.12.24458a7

Description

According to this datasheet: http://wiki.sunfounder.cc/images/7/72/QMC5883L-Datasheet-1.0.pdf
And also to my testing:
image

The basic address of the QMC5883L is 0x0D. The current configuration.h file suggest it should be 0x1E.

Relevant log output

No response
@Africmod Africmod added the bug Something isn't working label Jun 19, 2024
@a57224812
Copy link

The basic address is 0x0D. It is suggested to include 0x1E, which one is correct

@Africmod
Copy link
Author

The address on the QMC5883L is 0X0D I think the configuration.h file should match that.

@a57224812
Copy link

QMC5883L上的地址是 0X0D我认为 configuration.h 文件应该匹配它。
Thank you for your answer, but I can't drive it now whether I use 0X0D or 0X1E. I don't know what the reason is

@fifieldt
Copy link
Contributor

@caveman99 - you're in git blame for the 0x1E address for the QMC5883L. Did you have one to test with, or should we go with what the docs say?

@caveman99
Copy link
Sponsor Member

I have one but there's no support, I am just adding the sensor to detect. The actual implementation was done by somebody else it seems. I don't remember if I had it ever working.

fifieldt added a commit to fifieldt/meshtastic-firmware that referenced this issue Sep 17, 2024
@fifieldt
Fix I2C address for QMC5883L.
308d0f9 
QMC5883L and HMC5883L are 3-axis compasses which are often confused.
As reported by @Africmod, we had the wrong I2C address for the QMC5883L.
This patch fixes the address and adds its HMC5883L so we keep info
about both.

Fixes meshtastic#4144
@fifieldt fifieldt mentioned this issue Sep 17, 2024
Merged
@a57224812
Copy link

a57224812 commented Sep 17, 2024 via email

panaceya pushed a commit to mesh-mk-ua/meshtastic-firmware that referenced this issue Sep 20, 2024
@fifieldt @panaceya
Fix I2C address for QMC5883L.
484cc9e 
QMC5883L and HMC5883L are 3-axis compasses which are often confused.
As reported by @Africmod, we had the wrong I2C address for the QMC5883L.
This patch fixes the address and adds its HMC5883L so we keep info
about both.

Fixes meshtastic#4144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix I2C address for QMC5883L. fifieldt/meshtastic-firmware
4 participants
@caveman99 @fifieldt @Africmod @a57224812