Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings generated during compilation #4180

Open
thebentern opened this issue Jun 26, 2024 · 3 comments
Open

Warnings generated during compilation #4180

thebentern opened this issue Jun 26, 2024 · 3 comments
Assignees
Labels
tech debt Code or lib references that are not up to date or propper standards

Comments

@thebentern
Copy link
Contributor

thebentern commented Jun 26, 2024

Category

Other

Hardware

Not Applicable

Firmware Version

Current master

Description

Warnings generated during compilation

src/graphics/Screen.h:524:13: warning: 'void drawCompassNorth(OLEDDisplay*, int16_t, int16_t, float)' defined but not used [-Wunused-function]
 static void drawCompassNorth(OLEDDisplay *display, int16_t compassX, int16_t compassY, float myHeading)

Relevant log output

No response

@thebentern thebentern added the tech debt Code or lib references that are not up to date or propper standards label Jun 26, 2024
@jp-bennett
Copy link
Collaborator

@thebentern What target throws this warning? And the broader question, how do we want to handle functions that could be useful for multiple targets, but isn't used for all of them?

@thebentern
Copy link
Contributor Author

Multiple targets. Heltec V3 is a good example.
We can guardclause it if need-be.

@jp-bennett
Copy link
Collaborator

It seems like it's complaining because it's a static function, that's not part of the Screen class. Maybe the right answer here is to make it a normal class function instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Code or lib references that are not up to date or propper standards
Projects
None yet
Development

No branches or pull requests

3 participants