Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moveing auto generated protobuf glue into meshtastic.protobuf. #608

Closed
geeksville opened this issue Jun 22, 2024 · 2 comments
Closed

moveing auto generated protobuf glue into meshtastic.protobuf. #608

geeksville opened this issue Jun 22, 2024 · 2 comments
Assignees

Comments

@geeksville
Copy link
Member

geeksville commented Jun 22, 2024

Related to #579. What about moving the generated protobuf glue out of the root of the meshtastic project. Instead have it in meshtastic.protobuf. Do ya'll (in particular @ianmcorvidae) think that's a good idea?

If so, I can send in a PR soonish.

It will be a breaking change if there are any external users of our API that have reached in and touched those classes (though I didn't find any in my googling).

(Also I'm sorry I didn't do this originally before there was so many great folks using/improving this - it would have been less painful if they were in the right place all along)

@geeksville geeksville changed the title moveing auto generated protobuf glue into meshtastic.generated. moveing auto generated protobuf glue into meshtastic.protobuf. Jun 22, 2024
@geeksville geeksville self-assigned this Jun 24, 2024
@ianmcorvidae
Copy link
Contributor

I think this is a good idea.

I do know there's some folks who are importing the _pb2 modules directly in order to use them (particularly folks who are pulling stuff straight off MQTT). I think we can just be sure to mark it clearly in the release notes when we do it. It's not a huge change to stick in the extra folder in imports, so it shouldn't be a painful migration for anyone I don't think.

@geeksville
Copy link
Member Author

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants