Skip to content

Commit f76c131

Browse files
authored
Github Actions update (#2951)
Update setup-node action, release-drafter action and remove manual docker-compose step to fix tests.
1 parent 4cb53d7 commit f76c131

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

.github/workflows/frontend-tests.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
# We do not use this to install node but only to register problem matchers
3939
# so that eslint annotations work.
4040
- name: Setup Node.js environment to enable annotations
41-
uses: actions/setup-node@v3
41+
uses: actions/setup-node@v4
4242

4343
- name: Build frontend containers
4444
run: ./test.sh fe -b

.github/workflows/release-drafter.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@ jobs:
1111
runs-on: ubuntu-latest
1212
steps:
1313
# Drafts your next Release notes as Pull Requests are merged into "master"
14-
- uses: release-drafter/release-drafter@v5
14+
- uses: release-drafter/release-drafter@v6
1515
env:
1616
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/unit-tests.yml

-6
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,5 @@ jobs:
4343
run: echo ${{ secrets.DOCKER_HUB_PASSWORD }} | docker login -u ${{ secrets.DOCKER_HUB_USERNAME }} --password-stdin
4444
continue-on-error: true
4545

46-
# by default, docker-compose tries to pull the `listenbrainz` image used by timescale_writer as well.
47-
# but this is built locally for the listenbrainz service and reused for timescale writer, hence the pull fails.
48-
# to avoid this we specifically mention the services to pull images for here,
49-
- name: Pull docker images
50-
run: docker-compose -f docker/docker-compose.test.yml pull lb_db redis rabbitmq couchdb
51-
5246
- name: Run tests
5347
run: ./test.sh

0 commit comments

Comments
 (0)