-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inspect validation #152
base: master
Are you sure you want to change the base?
Inspect validation #152
Conversation
I don't know why but many tests are failing, you should review them, otherwise we cannot merge this. I'm setting this PR as a draft until it passes the tests. |
… that checks the deployments existence
f180c7a
to
f878601
Compare
@viferga It sees my secrets in my forked repo but it doesn't see base repo secrets in the pr workflow I think that's the problem. what do you see? |
I have added extra validation at the login with email and password flags. if the email and password are empty. the CLI asks for login with the |
@diaabadr I re-run the tests by doing a small change in the code, and they failed. You can review now and solve the issues if you want, meanwhile I am going to leave this PR as a draft. |
@viferga
I have added the new updates on the master branch with the
ensureDeploymentsExist