Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect validation #152

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

diaabadr
Copy link
Contributor

@viferga
I have added the new updates on the master branch with the ensureDeploymentsExist

@viferga
Copy link
Member

viferga commented Apr 28, 2023

I don't know why but many tests are failing, you should review them, otherwise we cannot merge this. I'm setting this PR as a draft until it passes the tests.

@viferga viferga marked this pull request as draft April 28, 2023 15:18
@diaabadr diaabadr force-pushed the inspect-validation branch 2 times, most recently from f180c7a to f878601 Compare April 29, 2023 02:28
@diaabadr
Copy link
Contributor Author

diaabadr commented Apr 29, 2023

@viferga
I think they are failing because of the secrets. workflows on a pull requests doesn't have access to the secrets. when i run it on my forked repo it passes the tests that doesn't require plans such as login, inspect, etc. my account doesn't have plans to test deploy, delete, etc. that's the reason they are failing here

image

It sees my secrets in my forked repo

image

but it doesn't see base repo secrets in the pr workflow

image

I think that's the problem. what do you see?

@diaabadr
Copy link
Contributor Author

I have added extra validation at the login with email and password flags. if the email and password are empty. the CLI asks for login with the auth choices (token or email). it doesn't consider them as invalid credentials so it doesn't throw an error to catch it and fail the login test. so i added a check on the info messages if it includes login successful or not.

@diaabadr diaabadr marked this pull request as ready for review April 29, 2023 21:21
@viferga
Copy link
Member

viferga commented Aug 27, 2024

@diaabadr I re-run the tests by doing a small change in the code, and they failed. You can review now and solve the issues if you want, meanwhile I am going to leave this PR as a draft.

@viferga viferga marked this pull request as draft August 27, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants