Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vega-lite to 5.2.0 #185

Open
fredZen opened this issue Dec 26, 2021 · 1 comment
Open

Bump vega-lite to 5.2.0 #185

fredZen opened this issue Dec 26, 2021 · 1 comment

Comments

@fredZen
Copy link

fredZen commented Dec 26, 2021

When I oz/view! a chart, I get different results that when I oz/export! them (for instance, grouped bar charts work better in view! than in export!... I am happy to provide screenshots or other details if it helps).

When I manually edit the exported html file to use vega-lite 5.2.0 instead of vega-lite 5.1.0, the differences go away and I get the behaviour I was expecting from my work in view!.

I believe this can be fixed by upgrading vega-lite in package.json (and upgrading package-lock.json accordingly).
I’m happy to make a pull-request if one is welcome.

@metasoarous
Copy link
Owner

Hi @fredZen. Thanks for reporting this.

This actually isn't a problem with the package.json versions, but rather with the version vars in oz.core, which are referenced in the html output. I failed to update them last time I updated the versions in package.json (which is what the view! interface is compiled against).

I'll try to take care of this next time I cut a release, but in the meantime, please feel free to submit a PR.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants