ingestors/golang: fix GetKeyValuePairValue to return correct value (#555)

Signed-off-by: Eng Zer Jun <[email protected]>

Author: Juneezee

ingestors/golang/metlo/block.go

@@ -125,7 +125,7 @@ func GetXForwardedForFromValue(value *string) *string {
 
 func GetSourceIp(reqHeaders []NV, traceMeta TraceMeta) *string {
 	for _, header := range reqHeaders {
-		if strings.ToLower(header.Name) == "x-forwarded-for" {
+		if strings.EqualFold(header.Name, "x-forwarded-for") {
 			xForwardedValue := GetXForwardedForFromValue(&header.Value)
 			return xForwardedValue
 		}
@@ -160,8 +160,8 @@ func CheckStringCondition(condOperator *string, condValue *string, reqValue *str
 
 func GetKeyValuePairValue(key string, keyValuePairs []NV) *string {
 	for _, pair := range keyValuePairs {
-		if strings.ToLower(pair.Name) == key {
-			return &pair.Name
+		if strings.EqualFold(pair.Name, key) {
+			return &pair.Value
 		}
 	}
 	return nil
@@ -222,7 +222,7 @@ func CheckKeyValuePair(condOperator *string, condKey *string, condValue *string,
 		return false
 	}
 	for _, pair := range keyValuePairs {
-		if strings.ToLower(pair.Name) == strings.ToLower(*condKey) && CheckStringCondition(condOperator, condValue, &pair.Value) {
+		if strings.EqualFold(pair.Name, *condKey) && CheckStringCondition(condOperator, condValue, &pair.Value) {
 			return true
 		}
 	}
@@ -424,7 +424,7 @@ func HandleSessionIdentifier(authentication *Authentication, headers []NV, key *
 			return
 		}
 		headerKey := *authentication.HeaderKey
-		headerValuePtr := GetKeyValuePairValue(strings.ToLower(headerKey), headers)
+		headerValuePtr := GetKeyValuePairValue(headerKey, headers)
 		if headerValuePtr != nil {
 			key.WriteRune('_')
 			key.WriteString(*headerValuePtr)

ingestors/golang/metlo/block_test.go

@@ -0,0 +1,48 @@
+package metlo
+
+import (
+	"testing"
+)
+
+func TestGetKeyValuePairValue(t *testing.T) {
+	keyValuePairs := []NV{
+		{Name: "key1", Value: "value1"},
+		{Name: "key2", Value: "value2"},
+		{Name: "key3", Value: "value3"},
+	}
+
+	t.Run("Existing key, case insensitive", func(t *testing.T) {
+		key := "KEY1"
+		expectedValue := "value1"
+
+		result := GetKeyValuePairValue(key, keyValuePairs)
+
+		if result == nil {
+			t.Errorf("Expected value for key '%s' to be '%s', but got nil", key, expectedValue)
+		} else if *result != expectedValue {
+			t.Errorf("Expected value for key '%s' to be '%s', but got '%s'", key, expectedValue, *result)
+		}
+	})
+
+	t.Run("Existing key, exact match", func(t *testing.T) {
+		key := "key3"
+		expectedValue := "value3"
+
+		result := GetKeyValuePairValue(key, keyValuePairs)
+
+		if result == nil {
+			t.Errorf("Expected value for key '%s' to be '%s', but got nil", key, expectedValue)
+		} else if *result != expectedValue {
+			t.Errorf("Expected value for key '%s' to be '%s', but got '%s'", key, expectedValue, *result)
+		}
+	})
+
+	t.Run("Non-existing key", func(t *testing.T) {
+		key := "nonexistent"
+		result := GetKeyValuePairValue(key, keyValuePairs)
+
+		if result != nil {
+			t.Errorf("Expected value for non-existing key '%s' to be nil, but got '%s'", key, *result)
+		}
+	})
+}