OrographicEnhancement CLI -> MetaOrographicEnhancement application #2221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpelley
changed the title
cpelley
commented
Oct 28, 2025
| if "surface_altitude" in cubes[ind].name(): | ||
| continue | ||
| cubes[ind] = self.extract_and_check(cubes[ind], *self._constraint_info) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I derived these names via the acceptance testing. Based on my previous experience for other acceptance tests, sometimes the acceptance test data has had incorrect names. Please verify the validity of the names used here for the extraction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing
OrographicEnhancementCLI via an application -- newMetaOrographicEnhancementapplication is created to migrate logic from the CLI layer to an application.MetaOrographicEnhancementprocess input arguments are made order insensitive, using cube extraction with metadata (we want to move away from assumed input argument ordering where possible).Largely a non-functional change, where the acceptance test continues to function as it was already, with the CLI now going via
MetaOrographicEnhancementinstead of handling its own logic then going viaOrographicEnhancement.