fix: adjusting tests to support httphost

Author: mtfelisb

src/test/java/com/mtfelisb/flink/connectors/elasticsearch/sink/ElasticsearchSinkBuilderTest.java

@@ -21,6 +21,7 @@
 
 package com.mtfelisb.flink.connectors.elasticsearch.sink;
 
+import org.apache.http.HttpHost;
 import org.junit.jupiter.api.Test;
 
 import static org.junit.Assert.assertEquals;
@@ -53,8 +54,7 @@ public void sinkBuilderSetEmitter() {
         Throwable exception = assertThrows(
             NullPointerException.class,
             () -> ElasticsearchSinkBuilder.<String>builder()
-                .setPort(9200)
-                .setHost("localhost")
+                .setHttpHost(new HttpHost("localhost", 9200))
                 .setPassword("password")
                 .setUsername("username")
                 .setEmitter(null)
@@ -66,7 +66,7 @@ public void sinkBuilderSetEmitter() {
     }
 
     /**
-     * The host should be declared to create
+     * The httpHost should be declared to create
      * a valid ElasticsearchSink instance
      *
      */
@@ -75,30 +75,13 @@ public void sinkBuilderSetHost() {
         Throwable exception = assertThrows(
             NullPointerException.class,
             () -> ElasticsearchSinkBuilder.<String>builder()
-                .setHost(null)
+                .setHttpHost(null)
                 .build()
         );
 
         assertEquals(null, exception.getMessage());
     }
 
-    /**
-     * The host should be declared to create
-     * a valid ElasticsearchSink instance
-     *
-     */
-    @Test
-    public void sinkBuilderSetHostEmpty() {
-        Throwable exception = assertThrows(
-            IllegalStateException.class,
-            () -> ElasticsearchSinkBuilder.<String>builder()
-                .setHost("")
-                .build()
-        );
-
-        assertEquals("Host cannot be empty", exception.getMessage());
-    }
-
     /**
      * The username, if provided, cannot be null to create
      * a valid ElasticsearchSink instance

src/test/java/com/mtfelisb/flink/connectors/elasticsearch/sink/ElasticsearchSinkTest.java

@@ -60,8 +60,7 @@ public void indexingByThresholdReached() throws Exception {
 
         final ElasticsearchSink<DummyData> sink = ElasticsearchSinkBuilder.<DummyData>builder()
             .setThreshold(2L)
-            .setHost(ES_CONTAINER.getHost())
-            .setPort(ES_CONTAINER.getFirstMappedPort())
+            .setHttpHost(HttpHost.create(ES_CONTAINER.getHttpHostAddress()))
             .setEmitter(
                 (value, op, ctx) ->
                     (BulkOperation.Builder) op
@@ -102,8 +101,7 @@ public void indexingByCheckpoint() throws Exception {
 
         final ElasticsearchSink<DummyData> sink = ElasticsearchSinkBuilder.<DummyData>builder()
             .setThreshold(1000L)
-            .setHost(ES_CONTAINER.getHost())
-            .setPort(ES_CONTAINER.getFirstMappedPort())
+            .setHttpHost(HttpHost.create(ES_CONTAINER.getHttpHostAddress()))
             .setEmitter(
                 (value, op, ctx) ->
                     (BulkOperation.Builder) op

src/test/java/com/mtfelisb/flink/connectors/elasticsearch/sink/NetworkConfigFactoryTest.java

@@ -22,6 +22,7 @@
 package com.mtfelisb.flink.connectors.elasticsearch.sink;
 
 import co.elastic.clients.elasticsearch.ElasticsearchClient;
+import org.apache.http.HttpHost;
 import org.testcontainers.junit.jupiter.Testcontainers;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertThrows;
@@ -38,7 +39,7 @@ public class NetworkConfigFactoryTest extends ElasticsearchSinkBaseITCase {
     public void requiredHost() {
         Throwable exception = assertThrows(
             NullPointerException.class,
-            () -> new NetworkConfigFactory(null, 9200, "username", "password"));
+            () -> new NetworkConfigFactory(null, "username", "password"));
 
         assertEquals(null, exception.getMessage());
     }
@@ -52,8 +53,7 @@ public void requiredHost() {
     @Test
     public void create() throws IOException {
         ElasticsearchClient esClient = new NetworkConfigFactory(
-            ES_CONTAINER.getHost(),
-            ES_CONTAINER.getFirstMappedPort(),
+            HttpHost.create(ES_CONTAINER.getHttpHostAddress()),
             null,
             null
         ).create();
@@ -70,8 +70,7 @@ public void create() throws IOException {
     @Test
     public void createWithUsernameAndPassword() throws IOException {
         ElasticsearchClient esClient = new NetworkConfigFactory(
-            ES_AUTH_CONTAINER.getHost(),
-            ES_AUTH_CONTAINER.getFirstMappedPort(),
+            HttpHost.create(ES_CONTAINER.getHttpHostAddress()),
             "elastic",
             "generic-pass"
         ).create();