From ed9fcb928f3fc62de975df6926358007982e772a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20K=C3=A4ufl?= Date: Tue, 16 Apr 2024 14:21:11 +0200 Subject: [PATCH] Modernize ref #1 --- .github/workflows/sanity.yml | 8 ++++---- .github/workflows/scrape.yml | 8 ++++---- main.py | 4 +--- 3 files changed, 9 insertions(+), 11 deletions(-) diff --git a/.github/workflows/sanity.yml b/.github/workflows/sanity.yml index 6a6797ee7..cd5ccc166 100644 --- a/.github/workflows/sanity.yml +++ b/.github/workflows/sanity.yml @@ -6,14 +6,14 @@ jobs: build: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Install Python 3 - uses: actions/setup-python@v1 + uses: actions/setup-python@v5 with: - python-version: 3.11 + python-version: 3.12 - name: Install dependencies run: | python -m pip install --upgrade pip - pip install -r requirements.txt + python -m pip install -r requirements.txt - name: Run tests with pytest run: python -m pytest diff --git a/.github/workflows/scrape.yml b/.github/workflows/scrape.yml index dad29d2af..5ab99b5e7 100644 --- a/.github/workflows/scrape.yml +++ b/.github/workflows/scrape.yml @@ -12,14 +12,14 @@ jobs: scheduled: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-python@v2 + - uses: actions/checkout@v4 + - uses: actions/setup-python@v5 with: - python-version: 3.11 + python-version: 3.12 - name: Install dependencies run: | python -m pip install --upgrade pip - pip install -r requirements.txt + python -m pip install -r requirements.txt - name: Fetch latest data and calculate change run: |- curl https://service.stuttgart.de/lhs-services/stoerung/ > incidents.html diff --git a/main.py b/main.py index 106fd6f0a..241cae870 100644 --- a/main.py +++ b/main.py @@ -25,9 +25,7 @@ def parse(contents): def load_previous_data(): filename = Path(f"data/{today().year}/{str(today())}.csv") if filename.exists(): - reader = csv.DictReader(open(filename)) - for row in reader: - yield row + yield from csv.DictReader(open(filename)) def merge(previous_incidents, incidents):