Skip to content

Fix $offset type in ItemList::offsetExists #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix $offset type in ItemList::offsetExists #914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13b8da4
TKey
mstrelan Oct 14, 2025
242f5cb
Merge branch 'main' into list-interface
mglaman Oct 16, 2025
12df882
Fix ListInterface extends to define TKey
mglaman Oct 16, 2025
2ebdd42
Merge branch 'main' into list-interface
mglaman Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stubs/Drupal/Core/Field/FieldItemListInterface.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use Drupal\Core\TypedData\ListInterface;

/**
* @template T of FieldItemInterface
* @extends ListInterface<T>
* @extends ListInterface<int, T>
* @property mixed $value
*/
interface FieldItemListInterface extends ListInterface {
Expand Down
5 changes: 3 additions & 2 deletions stubs/Drupal/Core/TypedData/ListInterface.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@
namespace Drupal\Core\TypedData;

/**
* @template TKey of int
* @template T of TypedDataInterface
* @extends TraversableTypedDataInterface<int, T>
* @extends \ArrayAccess<int,T>
* @extends TraversableTypedDataInterface<TKey, T>
* @extends \ArrayAccess<TKey,T>
*/
interface ListInterface extends TraversableTypedDataInterface, \ArrayAccess, \Countable {

Expand Down
2 changes: 1 addition & 1 deletion stubs/Drupal/Core/TypedData/Plugin/DataType/ItemList.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use Drupal\Core\TypedData\TypedDataInterface;
/**
* @template T of TypedDataInterface
* @implements \IteratorAggregate<int, T>
* @implements ListInterface<T>
* @implements ListInterface<int, T>
*/
class ItemList extends TypedData implements \IteratorAggregate, ListInterface {

Expand Down
Loading