Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Bug #244

Closed
mgreminger opened this issue Mar 4, 2024 · 0 comments · Fixed by #245
Closed

Integration Bug #244

mgreminger opened this issue Mar 4, 2024 · 0 comments · Fixed by #245
Labels
bug Something isn't working

Comments

@mgreminger
Copy link
Owner

mgreminger commented Mar 4, 2024 •
edited
Loading

Delayed substitution is causing errors with integrals that should have analytical solutions. This sheet reproduces the bug. The fix for this issue could possibly also fix #156

image
@mgreminger mgreminger added the bug Something isn't working label Mar 4, 2024
mgreminger added a commit that referenced this issue Mar 4, 2024
@mgreminger
test: add tests for calc substitution bugs #156 and #244
39e8559
mgreminger added a commit that referenced this issue Mar 24, 2024
@mgreminger
fix: integral substitution bug, fixes #244
69aad74 
nth order derivative units bug was introduced in last commit, this has also been fixed.  New tests added for nth order derivatives and numerical integral limits with compatible and incompatible units.
@mgreminger mgreminger linked a pull request Mar 24, 2024 that will close this issue
WIP fix calculus substitution bugs #156 and #244 #245
Merged
mgreminger added a commit that referenced this issue Mar 24, 2024
@mgreminger
Merge pull request #245 from mgreminger/calc-fix
4dde262 
WIP fix calculus substitution bugs #156 and #244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP fix calculus substitution bugs #156 and #244 mgreminger/EngineeringPaper.xyz
1 participant
@mgreminger