-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add homebrew for installation #29
Comments
Hi! Thanks for the suggestion. Do you mean homebrew for mac or homebrew for linux? I have zero experience with either, so it might be a while until I get around to doing this, but PRs are welcome! |
For mac. I also don't have experience how to add a homebrew package |
I have experience with adding packages to Homebrew and I would be happy to add Just so you know, Homebrew for Mac and Linux are the same thing: |
@mgunyho I started working on a Homebrew formula for I can make specifically tailor the wrappers listed in the README to work with Homebrew, but I'd like to know if you think that these wrappers have any chance of changing in the future (for example, #9 might break all old wrappers), as the formula will have to be manually updated if that happens. Other than this bit, I have completed the formula for |
One common solution is to add in |
+1 for tere available from brew, and especially for MacOS if possible. Installation of |
That's a great idea! I've seen projects like starship do things this way and it works really well. I would be willing to implement this feature myself and submit a pull request. @mgunyho do you support using this method of adding the shell wrappers? |
It's probably worth splitting the "add a subcommand for printing shell wrappers" idea into a separate issue, and it would be useful for all methods of installation, not just with Homebrew. I have created #47 for this purpose. |
Additionally, it might be worth it for me to submit my What are everyone's thoughts on this? |
Thanks @superatomic ! I think for now it's a good idea to just put the shell instructions in the caveats section. Feel free to submit the PR. How is the binary provided for homebrew? Will somebody have to build Currently I'm not planning to merge #9, it was more of a note to self after seeing how others like ranger and nnn do it. Maybe it can be added as an option, but for now let's say that the default will be to always just print to stdout. |
Sounds good, although I think it would be beneficial to eventually get #46 implemented.
The It is also possible to tell Homebrew to build from source locally during installation. |
You can now install While |
No description provided.
The text was updated successfully, but these errors were encountered: