Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Konami-Code fails on jQuery 1.8.0 #1

Open
gugahoi opened this issue Sep 17, 2012 · 4 comments
Open

Konami-Code fails on jQuery 1.8.0 #1

gugahoi opened this issue Sep 17, 2012 · 4 comments

Comments

@gugahoi
Copy link

gugahoi commented Sep 17, 2012

Trying to use it on jQuery 1.8.0 and getting js errors for all keypresses

Uncaught TypeError: Object true has no method 'apply' 

Click method works fine, and using ".on('keypress'...." also works.

@mhayes
Copy link
Owner

mhayes commented Sep 17, 2012

I just updated the index.html page in this project to use jQuery 1.8.0 and couldn't reproduce this issue. Can you send me a link to your site? Thanks!

@gugahoi
Copy link
Author

gugahoi commented Sep 17, 2012

I'll double check later then. I have just started using http://yeoman.io/ so it could be something with that.

However I managed to implement the code with mousetrap.js library. Works just as well and it can be activated multiple times on a single page load.

@dbrgn
Copy link

dbrgn commented Oct 16, 2012

Same problem here. It works with jQuery versions up to 1.5.2, but starts failing with 1.6.0.

@dbrgn
Copy link

dbrgn commented Oct 16, 2012

How to fix this bug: http://stackoverflow.com/a/11611363/284318

But anyways, I just realized this is already fixed in the current development version (even though the file is still called 1.0). So @mhayes, please upload the current version to the website :)

PS: You're mixing spaces and tabs in your js file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants