Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal issue 2972 - Numerous weirdnesses with IcDatePicker #3063

Open
ticket-sync bot opened this issue Jan 20, 2025 · 1 comment
Open

Internal issue 2972 - Numerous weirdnesses with IcDatePicker #3063

ticket-sync bot opened this issue Jan 20, 2025 · 1 comment
Milestone

Comments

@ticket-sync
Copy link

ticket-sync bot commented Jan 20, 2025

We’ve been testing the {{@ukic/canary-react}} {{2.0.0-canary.32}} version of {{IcDatePicker}} and have observed a number of issues or strange behaviours in this component.

When editing the field after a valid value has been set, an unexpected {{icChange}} event is fired when the user begins to edit the YYYY segment. This event has {{e.details.value}} set to {{null}} and can therefore cause the field to be blanked when the state is controlled externally.

This, expectedly, does not seem to be fired for when editing the month or day segments.

When {{min}} or {{max}} are set on the component (probably also {{disablePast}} / {{disableFuture}}), if a value outside of this range is typed in, no {{icChange}} event is fired. This prevents us from being able to validate the value ourselves and update our custom {{validationMessage}}.

Additionally, after an invalid value is entered into the field, tabbing onto or clicking the “Display calendar” button clears the entered value.

When using the picker dialog (which appears above the field, anchored at the bottom) to tab between months/years, the length of the month (in weeks) can cause the position of the “<“ and ”>” buttons to move.

This seems to be fixed in the version of the date picker used in the current ICDS website, where the dialog appears underneath the field, anchored at the top - although the position of the “Clear” and “Go to today” buttons can move instead.
Relatedly, if the field is near the top of the screen, the picker dialog will open mostly out-of-view (this also seems to be fixed in the version on the site).

@ticket-sync ticket-sync bot changed the title Internal issue 2972 Internal issue 2972 - Numerous weirdnesses with IcDatePicker Jan 24, 2025
@MI6-255 MI6-255 added this to the PI 11 V3 milestone Jan 24, 2025
@ad9242
Copy link
Contributor

ad9242 commented Jan 29, 2025

second issue may be linked to #3025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Refinement
Development

No branches or pull requests

2 participants