Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Don't spread array unnecessarily when using inverse array operations #7

Open
michaelboyles opened this issue Nov 1, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@michaelboyles
Copy link
Owner

When executing array operations which are the inverse of another such as

interface NumberArrayState {
    arr: number[]
}
const reducer = redcr((state: NumberArrayState) => {
    state.arr.push(123);
    state.arr.pop();
});

The generated code looks like this:

const reducer = (state) => {
    state = {
        ...state,
        arr: [...state.arr]
    };
    return state;
};

Both the ...state.arr spread and the ...state spread are pointless. It would be better if Redcr was smart enough to just remove them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant