Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stereoplots: Wrong setup of Scientific colour maps by F. Crameri #13

Open
yvonnefroehlich opened this issue Mar 4, 2024 · 0 comments
Open

Comments

@yvonnefroehlich
Copy link
Contributor

yvonnefroehlich commented Mar 4, 2024

First reported by @yvonnefroehlich in PR #4.

This issue focuses on an error in the function SWS_Analysis_BASIC_stereoplot.m regarding setting up the Scientific colour maps by F. Crameri.

By default, each MATLAB structure (one per colormap) contains 256 records or hues (.mat files available from Zenodo). Here, this is unchanged used to visualize the fast polarization direction (phi) with a value range of -90:1:90. As the colormap is not adjusted to fit to this different value range, the color-value assignment is wrong. Also, the related figures shown in the README are wrong.

One option is to use a MATLAB file exchange function (or https://github.com/chadagreene/crameri), as it is done in PR #4. However, this function is not updated promptly after a new release of the SCM. Of course, users can build the required mat structure by themselves (I do this). Despite this, I am currently thinking about finding another solution (thus I closed PR #4).

Example (using this function as provided, without any adjustments to make the plot look nice)
Stereo_crameri_color_value_assingement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant