Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would you consider adding type hints to your project? #29

Open
Colin-b opened this issue Jan 13, 2023 · 2 comments
Open

Would you consider adding type hints to your project? #29

Colin-b opened this issue Jan 13, 2023 · 2 comments

Comments

@Colin-b
Copy link

Colin-b commented Jan 13, 2023

And then package it as typed so that mypy can run checks on it?
@DavidKaub
Copy link

@michaelkryukov assuming I'd provide the types; Would you merge the PR?

@michaelkryukov
Copy link
Owner

@DavidKaub yes, I'll review the PR, and if the changes are beneficial and don't introduce any issues, I'll merge it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Colin-b @michaelkryukov @DavidKaub