Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing TrieKey impls for paths on Windows #54

Open
michaelsproul opened this issue Nov 17, 2019 · 0 comments
Open

Missing TrieKey impls for paths on Windows #54

michaelsproul opened this issue Nov 17, 2019 · 0 comments
Labels
help wanted

Comments

@michaelsproul
Copy link
Owner

Due to OsStrings not losslessly converting to UTF-8 (and therefore bytes) on Windows (see SO, Rust docs), we are currently missing an implementation of TrieKey for Path/PathBuf.

One solution might be to use the OsStr::to_string_lossy function.
michaelsproul added a commit that referenced this issue Nov 17, 2019
@michaelsproul
Remove panicky TrieKey impl for Path/PathBuf
a74fb7f 
See #54 for a long-term resolution
@michaelsproul michaelsproul mentioned this issue Nov 17, 2019
Merged
michaelsproul added a commit that referenced this issue Nov 17, 2019
@michaelsproul
Remove panicky TrieKey impl for Path/PathBuf
7587428 
See #54 for a long-term resolution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelsproul