Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom attributes with quotes? #367

Open
jerry1970 opened this issue Jan 7, 2022 · 1 comment
Open

Custom attributes with quotes? #367

jerry1970 opened this issue Jan 7, 2022 · 1 comment

Comments

@jerry1970
Copy link

Currently the extra attributes cannot take a quotes string. So {attr1=abc attr2="def ghi"} does not work.

The source regex is this:

protected $id_class_attr_catch_re = '\{((?>[ ]*[#.a-z][-_:a-zA-Z0-9=]+){1,})[ ]*\}';

Is there a reason why quoted attributes are not possible?

I am going to see if I can change this to make it work in a derived class, if this is not on the list yet.

Question: the {1,}, is there a reason why this is not +?

Thanks!

@michelf
Copy link
Owner

michelf commented Jan 7, 2022

I don't think there is any particular reason it's not supported. Feel free to work on this, it'd be a good addition.

I don't think there is any particular reason for {1,}instead of +. You can change it if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants