Skip to content

feat: add _mnn #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
michen00 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add _mnn #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ Add the above line to your favorite shell configuration file (e.g. `~/.bashrc`,

- [`ach`](ach): Add the last commit hash to a given file (`.git-blame-ignore-revs` file by default).
- [`chdirx`](chdirx): Add `+x` permission to all executable files (that start with `#!`) in the given directory.
- [`em_`](em_) / [`en_`](en_): Copy typographic dashes to the system clipboard. `em_` copies em dash (—, Unicode U+2014), `en_` copies en dash (–, Unicode U+2013).
- [`gcfixup`](gcfixup): Create a fixup commit and automatically rebase with autosquash.
- [`git-shed`](git-shed): Identify and remove merged & stale branches with respect to a target branch.
- [`how-big`](how-big): Show the size of the given directory.
Expand Down
195 changes: 195 additions & 0 deletions _mnn
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,195 @@
#!/usr/bin/env bash

set -euo pipefail

SCRIPT_NAME=$(basename "$0")

# Trap handlers for error recovery
trap 'cleanup_on_error' ERR
trap 'cleanup_on_exit' EXIT

cleanup_on_error() {
local exit_code=$?
echo "Error: Script failed with exit code $exit_code" >&2
exit $exit_code
}

cleanup_on_exit() {
# Cleanup logic if needed
:
}

# Detect platform
detect_platform() {
case "$(uname -s)" in
Darwin*)
echo "macos"
;;
Linux*)
if [[ -n "${WAYLAND_DISPLAY:-}" ]]; then
echo "wayland"
else
echo "x11"
fi
;;
CYGWIN* | MINGW* | MSYS*)
echo "windows"
;;
*)
echo "unknown"
;;
esac
}

# Select clipboard command based on platform
select_clipboard_command() {
local platform=$1
case "$platform" in
macos)
if command -v pbcopy >/dev/null 2>&1; then
echo "pbcopy"
else
echo "ERROR:pbcopy not found"
fi
;;
x11)
if command -v xclip >/dev/null 2>&1; then
echo "xclip -selection clipboard"
elif command -v xsel >/dev/null 2>&1; then
echo "xsel --clipboard"
else
echo "ERROR:xclip or xsel not found"
fi
;;
wayland)
if command -v wl-copy >/dev/null 2>&1; then
echo "wl-copy"
else
echo "ERROR:wl-copy not found"
fi
;;
windows)
if command -v clip.exe >/dev/null 2>&1; then
echo "clip.exe"
else
echo "ERROR:clip.exe not found"
fi
;;
*)
echo "ERROR:unsupported platform"
;;
esac
}
Comment on lines +45 to +82
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Returning error messages as strings (e.g., ERROR:pbcopy not found) and checking for them with string comparisons is a viable but somewhat brittle approach. A more idiomatic and robust pattern in shell scripting, especially when using set -e, is to have functions report errors on stderr and return a non-zero exit code. The calling code can then rely on set -e to halt execution automatically on failure.

For example, select_clipboard_command could be refactored to echo errors to stderr and return 1. Then in main, you could simply call it and let the script exit if it fails.


# Select dash character based on script name
select_dash() {
case "$SCRIPT_NAME" in
en_)
echo "–" # en dash U+2013
;;
em_)
echo "—" # em dash U+2014
;;
*)
echo "ERROR:invalid script name"
;;
esac
}

# Display help message
usage() {
cat <<EOF
Usage: $SCRIPT_NAME [OPTIONS]

Copies $(if [[ "$SCRIPT_NAME" == "en_" ]]; then echo "en dash"; else echo "em dash"; fi) (Unicode U+$(if [[ "$SCRIPT_NAME" == "en_" ]]; then echo "2013"; else echo "2014"; fi)) to the system clipboard.

Options:
-h, --help Show this help message and exit.

Examples:
$SCRIPT_NAME # Copy $(if [[ "$SCRIPT_NAME" == "en_" ]]; then echo "en dash (–)"; else echo "em dash (—)"; fi) to clipboard

Note: This script must be invoked as 'en_' or 'em_'. The dash character
copied is determined by the command name used.
EOF
exit 0
}

# Main execution
main() {
# Parse command-line arguments
if [[ $# -gt 0 ]]; then
case "$1" in
-h | --help)
usage
;;
*)
echo "Error: Unknown option '$1'" >&2
echo "Run '$SCRIPT_NAME --help' for usage information." >&2
exit 2
;;
esac
fi

# Validate script name
if [[ "$SCRIPT_NAME" == "_mnn" ]]; then
echo "Error: This script must be invoked as 'en_' or 'em_'" >&2
exit 1
fi
Comment on lines +135 to +138
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This explicit check for _mnn is redundant. The select_dash function, which is called shortly after, already has a default *) case that handles any script name other than en_ or em_, including _mnn. You can safely remove this block to simplify the code.


# Select dash character
local dash
dash=$(select_dash)
if [[ "$dash" == ERROR:* ]]; then
echo "Error: This script must be invoked as 'en_' or 'em_'" >&2
exit 1
fi

# Detect platform
local platform
platform=$(detect_platform)
if [[ "$platform" == "unknown" ]]; then
local uname_output
uname_output=$(uname -s)
echo "Error: Unsupported platform: $uname_output. This script supports macOS, Linux (X11/Wayland), and Windows." >&2
exit 1
fi

# Select clipboard command
local clipboard_cmd
clipboard_cmd=$(select_clipboard_command "$platform")
if [[ "$clipboard_cmd" == ERROR:* ]]; then
case "$platform" in
macos)
echo "Error: Clipboard tool 'pbcopy' not found. This should be available on macOS." >&2
;;
x11)
echo "Error: Clipboard tool 'xclip' or 'xsel' not found. Please install xclip (preferred) or xsel." >&2
;;
wayland)
echo "Error: Clipboard tool 'wl-copy' not found. Please install wl-clipboard package." >&2
;;
windows)
echo "Error: Clipboard tool 'clip.exe' not found. This should be available on Windows." >&2
;;
esac
exit 1
fi

# Copy to clipboard
if [[ "$platform" == "windows" ]]; then
# Windows echo doesn't support -n flag
echo "$dash" | $clipboard_cmd || {
echo "Error: Failed to copy to clipboard: $?" >&2
exit 1
}
else
# Unix-like systems support echo -n
echo -n "$dash" | $clipboard_cmd || {
echo "Error: Failed to copy to clipboard: $?" >&2
exit 1
}
fi
Comment on lines +180 to +192
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of using a platform-specific if/else to handle the -n flag for echo, you can use printf. The printf "%s" "$dash" command is more portable and behaves consistently across different shells and operating systems, including Windows environments like MSYS/Cygwin. This simplifies your code by removing the conditional block.

	# Copy to clipboard
	printf "%s" "$dash" | $clipboard_cmd || {
		echo "Error: Failed to copy to clipboard: $?" >&2
		exit 1
	}

}

main "$@"
1 change: 1 addition & 0 deletions em_
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
_mnn
1 change: 1 addition & 0 deletions en_
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
_mnn
Loading
Loading