Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In recipes - add option to create non-ephemeral or ephemeral nodes #21

Open
nonspher opened this issue May 29, 2018 · 1 comment
Open

Comments

@nonspher
Copy link

nonspher commented May 29, 2018

Hello! Could We add option to create non-ephemeral or ephemeral nodes into Recipes(Lock, SharedLock)? Like in kazoo https://github.com/python-zk/kazoo/blob/master/kazoo/recipe/lock.py#LC129
I can do it

@cybergrind
Copy link
Member

@nonspher I'm not against, but personally, I don't see too much sense in having non-ephemeral locks for most cases.
For example, if some process just dies, you will have basically deadlock. From my point of view, it is better not to push bad design decisions. If someone needs it is really easy to subclass lock and make it explicit.

If you want to implement it, feel free to make PR + tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants