Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring for v1.0 #67

Open
cybergrind opened this issue Jul 11, 2020 · 5 comments
Open

Refactoring for v1.0 #67

cybergrind opened this issue Jul 11, 2020 · 5 comments
Assignees

Comments

@cybergrind
Copy link
Member

cybergrind commented Jul 11, 2020

Since we've started to break API's it is probably a good time to make more changes. Let's get our ideas in issues and then split and code them.

https://github.com/micro-fan/aiozk/projects/1

@cybergrind
Copy link
Member Author

@rhdxmr I believe we can get rid of Recipe.sub_recipes: the only function of it that I can see is to facilitate the propagation of client in Recipe.set_client and probably can be done better:

  1. introspection of __dir__ contents for isinstance(Recipe). Won't require many changes to do
  2. We can add an optional parent parameters to the construction. Will require more changes but makes it explicit

What do you think?

@rhdxmr
Copy link
Collaborator

rhdxmr commented Jul 13, 2020

@rhdxmr I believe we can get rid of Recipe.sub_recipes: the only function of it that I can see is to facilitate the propagation of client in Recipe.set_client and probably can be done better:

  1. introspection of __dir__ contents for isinstance(Recipe). Won't require many changes to do
  2. We can add an optional parent parameters to the construction. Will require more changes but makes it explicit

What do you think?

I don't understand your first suggestion. I am sorry.
How can we use __dir__ instead of .sub_recipes? And what does __dir__ have to do with isinstance(Recipe)?

And for the second suggestion, I guess you mean adding parent parameter to sub recipes. Is it right?

@rhdxmr
Copy link
Collaborator

rhdxmr commented Jul 13, 2020

Connection.abort method seems WIP. It should be improved.

@rhdxmr
Copy link
Collaborator

rhdxmr commented Jul 13, 2020

To release the 1.0.0 version, we should ensure that aiozk is stable enough.
So I think we need to make up for test code and keep test code coverage stats high.

Besides documents should be completed for normal users.

It would be good to create other issues for these must-do's.

@cybergrind
Copy link
Member Author

So I think we need to make up for test code and keep test code coverage stats high.

yeah, already put it to the list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants