binary file should be open with 'rb' instead of 'r' in advanced exemple

[pidou46]

With mp 1.24 , in advanced usage exemple: <with open('test.ulp', 'r') as f:> rise a unicode exception

It should be changed to:
<with open('test.ulp', 'rb') as f:>

[ThomasWaldmann]

guess this refers to item 3 there: https://github.com/micropython/micropython-esp32-ulp/blob/master/docs/index.rst#advanced-usage

sure, reading binary files should always use "rb" mode.

can you submit a PR?

[pidou46]

Yes, it's. I will try to submit a PR, m'y knowlage with git is very thinght but the modification is trivial so I shoud be able to do it. The code worked with earlier mp version, so I guess I should try to see if this PR would work with previous mp versions (1.12 ?) priori to submit it?

…

Le 3 nov. 2024 à 11:02, TW ***@***.***> a écrit : guess this refers to item 3 there: https://github.com/micropython/micropython-esp32-ulp/blob/master/docs/index.rst#advanced-usage sure, reading binary files should always use "rb" mode. can you submit a PR? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

[ThomasWaldmann]

I don't think you need to check with old micropython versions, just with the current one.