Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI to set individual device settings #901

Open
carandraug opened this issue Aug 21, 2024 · 4 comments
Open

UI to set individual device settings #901

carandraug opened this issue Aug 21, 2024 · 4 comments

Comments

@carandraug
Copy link
Collaborator

Currently, the only devices that expose the settings dict in cockpit are cameras through their settings button on the main window:

Screenshot from 2024-08-21 13-41-57

But all Python-Microscope devices have a settings dict. Would be nice to expose that but not all devices have space for them on the main window. I'm thinking the simplest thing would be to add a menu bar for devices that would open those as separate windows. (requested by @LauraA-Octopus on image.sc https://forum.image.sc/t/adding-settings-on-stage-controller/100713)

@carandraug
Copy link
Collaborator Author

I have implemented a minimal solution on my 901-devices-menu branch:

Screenshot from 2024-08-21 13-47-12

This does not filter devices that are not Python-Microscope devices. We probably could group them by type somehow. And the "setings" button beneath the camera does some extra things that I'm not sure what they are for. But this is a start for people to comment and maybe use as hint to implement better.

@iandobbie
Copy link
Collaborator

Seems like a good idea.

@LauraA-Octopus
Copy link

This seems indeed a good idea, I can try it in the lab probably this Friday. Hopefully this will solve the issue, otherwise I will have to write a custom class for the AMC in cockpit, which I'd rather avoid since you are trying to be not device specific

@juliomateoslangerak
Copy link
Contributor

Good idea. I might consider renaming the menu to Settings or Device settings though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants